Hide default download folder option if it's not available

Telegram/Resources/langs/lang.strings

@@ -755,6 +755,7 @@ https://github.com/telegramdesktop/tdesktop/blob/master/LEGAL
 "lng_download_path" = "Download path";
 "lng_download_path_temp" = "Temp folder";
 "lng_download_path_default" = "Default folder";
+"lng_download_path_unset" = "Unset";
 "lng_download_path_clear" = "Clear all";
 "lng_download_path_header" = "Choose download path";
 "lng_download_path_default_radio" = "Telegram folder in system «Downloads»";

Telegram/SourceFiles/boxes/download_path_box.cpp

@@ -25,7 +25,14 @@ DownloadPathBox::DownloadPathBox(
 , _path(Core::App().settings().downloadPath())
 , _pathBookmark(Core::App().settings().downloadPathBookmark())
 , _group(std::make_shared<Ui::RadioenumGroup<Directory>>(typeFromPath(_path)))
-, _default(this, _group, Directory::Downloads, tr::lng_download_path_default_radio(tr::now), st::defaultBoxCheckbox)
+, _default(Core::App().canReadDefaultDownloadPath(true)
+	? object_ptr<Ui::Radioenum<Directory>>(
+		this,
+		_group,
+		Directory::Downloads,
+		tr::lng_download_path_default_radio(tr::now),
+		st::defaultBoxCheckbox)
+	: nullptr)
 , _temp(this, _group, Directory::Temp, tr::lng_download_path_temp_radio(tr::now), st::defaultBoxCheckbox)
 , _dir(this, _group, Directory::Custom, tr::lng_download_path_dir_radio(tr::now), st::defaultBoxCheckbox)
 , _pathLink(this, QString(), st::boxLinkButton) {
@@ -50,7 +57,7 @@ void DownloadPathBox::updateControlsVisibility() {
 	auto custom = (_group->value() == Directory::Custom);
 	_pathLink->setVisible(custom);
 
-	auto newHeight = st::boxOptionListPadding.top() + _default->getMargins().top() + _default->heightNoMargins() + st::boxOptionListSkip + _temp->heightNoMargins() + st::boxOptionListSkip + _dir->heightNoMargins();
+	auto newHeight = st::boxOptionListPadding.top() + (_default ? _default->getMargins().top() + _default->heightNoMargins() : 0) + st::boxOptionListSkip + _temp->heightNoMargins() + st::boxOptionListSkip + _dir->heightNoMargins();
 	if (custom) {
 		newHeight += st::downloadPathSkip + _pathLink->height();
 	}
@@ -62,8 +69,10 @@ void DownloadPathBox::updateControlsVisibility() {
 void DownloadPathBox::resizeEvent(QResizeEvent *e) {
 	BoxContent::resizeEvent(e);
 
-	_default->moveToLeft(st::boxPadding.left() + st::boxOptionListPadding.left(), st::boxOptionListPadding.top() + _default->getMargins().top());
-	_temp->moveToLeft(st::boxPadding.left() + st::boxOptionListPadding.left(), _default->bottomNoMargins() + st::boxOptionListSkip);
+	if (_default) {
+		_default->moveToLeft(st::boxPadding.left() + st::boxOptionListPadding.left(), st::boxOptionListPadding.top() + _default->getMargins().top());
+	}
+	_temp->moveToLeft(st::boxPadding.left() + st::boxOptionListPadding.left(), (_default ? _default->bottomNoMargins() : 0) + st::boxOptionListSkip);
 	_dir->moveToLeft(st::boxPadding.left() + st::boxOptionListPadding.left(), _temp->bottomNoMargins() + st::boxOptionListSkip);
 	auto inputx = st::boxPadding.left() + st::boxOptionListPadding.left() + st::defaultCheck.diameter + st::defaultBoxCheckbox.textPosition.x();
 	auto inputy = _dir->bottomNoMargins() + st::downloadPathSkip;

Telegram/SourceFiles/core/application.cpp

@@ -595,11 +595,9 @@ void Application::saveSettings() {
 	Local::writeSettings();
 }
 
-bool Application::canSaveFileWithoutAskingForPath() const {
-	if (Core::App().settings().askDownloadPath()) {
-		return false;
-	} else if (KSandbox::isInside()
-		&& Core::App().settings().downloadPath().isEmpty()) {
+bool Application::canReadDefaultDownloadPath(bool always) const {
+	if (KSandbox::isInside()
+		&& (always || Core::App().settings().downloadPath().isEmpty())) {
 		const auto path = QStandardPaths::writableLocation(
 			QStandardPaths::DownloadLocation);
 		return base::CanReadDirectory(path);
@@ -607,6 +605,11 @@ bool Application::canSaveFileWithoutAskingForPath() const {
 	return true;
 }
 
+bool Application::canSaveFileWithoutAskingForPath() const {
+	return !Core::App().settings().askDownloadPath()
+		&& canReadDefaultDownloadPath();
+}
+
 MTP::Config &Application::fallbackProductionConfig() const {
 	if (!_fallbackProductionConfig) {
 		_fallbackProductionConfig = std::make_unique<MTP::Config>(

Telegram/SourceFiles/core/application.h

@@ -178,6 +178,8 @@ public:
 	[[nodiscard]] Settings &settings();
 	void saveSettingsDelayed(crl::time delay = kDefaultSaveDelay);
 	void saveSettings();
+
+	[[nodiscard]] bool canReadDefaultDownloadPath(bool always = false) const;
 	[[nodiscard]] bool canSaveFileWithoutAskingForPath() const;
 
 	// Fallback config and proxy.

Telegram/SourceFiles/core/file_utilities.cpp

@@ -24,8 +24,6 @@ https://github.com/telegramdesktop/tdesktop/blob/master/LEGAL
 #include <QtCore/QStandardPaths>
 #include <QtGui/QDesktopServices>
 
-#include <ksandbox.h>
-
 bool filedialogGetSaveFile(
 		QPointer<QWidget> parent,
 		QString &file,
@@ -173,15 +171,12 @@ QString DefaultDownloadPathFolder(not_null<Main::Session*> session) {
 }
 
 QString DefaultDownloadPath(not_null<Main::Session*> session) {
-	const auto standardLocation = QStandardPaths::writableLocation(
-		QStandardPaths::DownloadLocation);
-	const auto realDefaultPath = standardLocation
+	const auto realDefaultPath = QStandardPaths::writableLocation(
+		QStandardPaths::DownloadLocation)
 		+ '/'
 		+ DefaultDownloadPathFolder(session)
 		+ '/';
-	if (KSandbox::isInside()
-		&& Core::App().settings().downloadPath().isEmpty()
-		&& !base::CanReadDirectory(standardLocation)) {
+	if (!Core::App().canReadDefaultDownloadPath()) {
 		QStringList files;
 		QByteArray remoteContent;
 		const auto success = Platform::FileDialog::Get(

Telegram/SourceFiles/settings/settings_chat.cpp

@@ -1055,7 +1055,9 @@ void SetupDataStorage(
 	auto pathtext = Core::App().settings().downloadPathValue(
 	) | rpl::map([](const QString &text) {
 		if (text.isEmpty()) {
-			return tr::lng_download_path_default(tr::now);
+			return Core::App().canReadDefaultDownloadPath(true)
+				? tr::lng_download_path_default(tr::now)
+				: tr::lng_download_path_unset(tr::now);
 		} else if (text == FileDialog::Tmp()) {
 			return tr::lng_download_path_temp(tr::now);
 		}