From 5d0795dbd02781342cfd32311ab6431c9b1d9c21 Mon Sep 17 00:00:00 2001 From: okaestne Date: Tue, 29 Aug 2023 00:18:24 +0200 Subject: [PATCH] dd: simplify code --- src/datadragon.cpp | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/datadragon.cpp b/src/datadragon.cpp index f9ec1c0..9ec2aa2 100644 --- a/src/datadragon.cpp +++ b/src/datadragon.cpp @@ -321,12 +321,11 @@ void DataDragon::getChampsInternal() { QJsonObject obj = jchamps.object(); auto it = obj.constFind("data"); - if(it != obj.constEnd() && it.value().isObject()) { - QJsonObject jchampsdata = it.value().toObject(); - for(auto champit = jchampsdata.constBegin(); champit != jchampsdata.constEnd(); champit++) { - if(champit.value().isObject()) { - champs.emplace_back(champit.value().toObject()); - notDownloadedImages.insert(champs.back().id); + if(it != obj.constEnd() && it->isObject()) { + for(auto&& champdata : it->toObject()) { + if(champdata.isObject()) { + auto& dataobj = champs.emplace_back(champdata.toObject()); + notDownloadedImages.insert(dataobj.id); } } }