MrBesen
/
ffmpeg
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tools/graph2dot: Don't use sizeof(AVFilterGraph), check allocation 

Use avfilter_graph_alloc() instead of av_mallocz(sizeof(AVFilterGraph))
to allocate an AVFilterGraph; this also properly allocates the graph's
internal. The current code just happened to work because it did not
make any use of said internal.

Also check the allocation; this fixes Coverity #1292528.

Reviewed-by: Jan Ekström <jeebjp@gmail.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
This commit is contained in:
Andreas Rheinhardt 2021-07-22 09:01:27 +02:00
parent 4ff73add5d
commit c253b180cb
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tools/graph2dot.c
View File

@ -113,7 +113,7 @@ int main(int argc, char **argv)
FILE *outfile = NULL;
FILE *infile = NULL;
char *graph_string = NULL;
AVFilterGraph *graph = av_mallocz(sizeof(AVFilterGraph));
AVFilterGraph *graph = NULL;
char c;
av_log_set_level(AV_LOG_DEBUG);
@ -189,6 +189,12 @@ int main(int argc, char **argv)
*p = '\0';
}
graph = avfilter_graph_alloc();
if (!graph) {
fprintf(stderr, "Memory allocation failure\n");
return 1;
}
if (avfilter_graph_parse(graph, graph_string, NULL, NULL, NULL) < 0) {
fprintf(stderr, "Failed to parse the graph description\n");
return 1;