MrBesen/ffmpeg
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

avcodec/indeo3data: fix undefined left shift of negative number

Browse Source 
This fixes a whole sea of -Wshift-negative-value reported with clang 3.7+, e.g
http://fate.ffmpeg.org/log.cgi?time=20150918181527&log=compile&slot=x86_64-darwin-clang-polly-vectorize-stripmine-3.7.
Any half decent compiler should anyway optimize away the multiplication.

Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>
This commit is contained in:
Ganesh Ajjanagadde 2015-09-19 02:43:39 -03:00 committed by James Almer
parent 3693efb315
commit 8c9853a69b
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libavcodec/indeo3data.h
View File

@ -238,9 +238,9 @@
* according with endianness of the host machine.
*/
#if HAVE_BIGENDIAN
#define PD(a,b) (((a) << 8) + (b))
#define PD(a,b) (((a) * (1 << 8)) + (b))
#else
#define PD(a,b) (((b) << 8) + (a))
#define PD(a,b) (((b) * (1 << 8)) + (a))
#endif
/**
@ -285,9 +285,9 @@ static const int16_t delta_tab_3_5[79] = { TAB_3_5 };
* according with endianness of the host machine.
*/
#if HAVE_BIGENDIAN
#define PD(a,b) (((a) << 24) + ((a) << 16) + ((b) << 8) + (b))
#define PD(a,b) (((a) * (1 << 24)) + ((a) * (1 << 16)) + ((b) * (1 << 8)) + (b))
#else
#define PD(a,b) (((b) << 24) + ((b) << 16) + ((a) << 8) + (a))
#define PD(a,b) (((b) * (1 << 24)) + ((b) * (1 << 16)) + ((a) * (1 << 8)) + (a))
#endif
/*