From 4c8ca76965b1c29758246624940cbc529e7141f0 Mon Sep 17 00:00:00 2001 From: Ganesh Ajjanagadde Date: Fri, 9 Oct 2015 11:25:16 -0400 Subject: [PATCH] ffserver_config: check for INT_MIN before doing FFABS FFABS(INT_MIN) is not safe. Alternative of using FFNABS is not as readable. Reviewed-by: Michael Niedermayer Signed-off-by: Ganesh Ajjanagadde --- ffserver_config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffserver_config.c b/ffserver_config.c index 691ff7b49e..9fc1f0030c 100644 --- a/ffserver_config.c +++ b/ffserver_config.c @@ -460,7 +460,7 @@ static int ffserver_set_int_param(int *dest, const char *value, int factor, if (tmp < min || tmp > max) goto error; if (factor) { - if (FFABS(tmp) > INT_MAX / FFABS(factor)) + if (tmp == INT_MIN || FFABS(tmp) > INT_MAX / FFABS(factor)) goto error; tmp *= factor; }