From 28ffc39808f6e203291430515b22b7b6d1755329 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Sun, 7 Apr 2024 20:04:20 +0200 Subject: [PATCH] avcodec/ac3enc: Move EAC-3 specific initialization to eac3enc.c Signed-off-by: Andreas Rheinhardt --- libavcodec/ac3enc.c | 8 +------- libavcodec/eac3enc.c | 26 ++++++++++++++++++++++---- libavcodec/eac3enc.h | 10 ---------- 3 files changed, 23 insertions(+), 21 deletions(-) diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c index 564c4d96f6..b74ea6b2e7 100644 --- a/libavcodec/ac3enc.c +++ b/libavcodec/ac3enc.c @@ -2555,8 +2555,6 @@ av_cold int ff_ac3_encode_init(AVCodecContext *avctx) s->avctx = avctx; - s->eac3 = avctx->codec_id == AV_CODEC_ID_EAC3; - ret = validate_options(s); if (ret) return ret; @@ -2579,11 +2577,7 @@ av_cold int ff_ac3_encode_init(AVCodecContext *avctx) s->crc_inv[1] = pow_poly((CRC16_POLY >> 1), (8 * frame_size_58) - 16, CRC16_POLY); } - if (CONFIG_EAC3_ENCODER && s->eac3) { - static AVOnce init_static_once_eac3 = AV_ONCE_INIT; - ff_thread_once(&init_static_once_eac3, ff_eac3_exponent_init); - s->output_frame_header = ff_eac3_output_frame_header; - } else + if (!s->output_frame_header) s->output_frame_header = ac3_output_frame_header; set_bandwidth(s); diff --git a/libavcodec/eac3enc.c b/libavcodec/eac3enc.c index 1ee140f13a..c957174a70 100644 --- a/libavcodec/eac3enc.c +++ b/libavcodec/eac3enc.c @@ -27,6 +27,7 @@ #define AC3ENC_FLOAT 1 #include "libavutil/attributes.h" +#include "libavutil/thread.h" #include "ac3enc.h" #include "codec_internal.h" #include "eac3enc.h" @@ -47,7 +48,10 @@ static const AVClass eac3enc_class = { static int8_t eac3_frame_expstr_index_tab[3][4][4][4][4][4]; -av_cold void ff_eac3_exponent_init(void) +/** + * Initialize E-AC-3 exponent tables. + */ +static av_cold void eac3_exponent_init(void) { int i; @@ -122,8 +126,10 @@ void ff_eac3_set_cpl_states(AC3EncodeContext *s) } } - -void ff_eac3_output_frame_header(AC3EncodeContext *s) +/** + * Write the E-AC-3 frame header to the output bitstream. + */ +static void eac3_output_frame_header(AC3EncodeContext *s) { int blk, ch; AC3EncOptions *opt = &s->options; @@ -243,6 +249,18 @@ void ff_eac3_output_frame_header(AC3EncodeContext *s) put_bits(&s->pb, 1, 0); } +static av_cold int eac3_encode_init(AVCodecContext *avctx) +{ + static AVOnce init_static_once = AV_ONCE_INIT; + AC3EncodeContext *s = avctx->priv_data; + + s->eac3 = 1; + s->output_frame_header = eac3_output_frame_header; + + ff_thread_once(&init_static_once, eac3_exponent_init); + + return ff_ac3_float_encode_init(avctx); +} const FFCodec ff_eac3_encoder = { .p.name = "eac3", @@ -251,7 +269,7 @@ const FFCodec ff_eac3_encoder = { .p.id = AV_CODEC_ID_EAC3, .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE, .priv_data_size = sizeof(AC3EncodeContext), - .init = ff_ac3_float_encode_init, + .init = eac3_encode_init, FF_CODEC_ENCODE_CB(ff_ac3_encode_frame), .close = ff_ac3_encode_close, .p.sample_fmts = (const enum AVSampleFormat[]){ AV_SAMPLE_FMT_FLTP, diff --git a/libavcodec/eac3enc.h b/libavcodec/eac3enc.h index 7d6155975d..0523de411b 100644 --- a/libavcodec/eac3enc.h +++ b/libavcodec/eac3enc.h @@ -29,11 +29,6 @@ #include "ac3enc.h" -/** - * Initialize E-AC-3 exponent tables. - */ -void ff_eac3_exponent_init(void); - /** * Determine frame exponent strategy use and indices. */ @@ -46,9 +41,4 @@ void ff_eac3_get_frame_exp_strategy(AC3EncodeContext *s); */ void ff_eac3_set_cpl_states(AC3EncodeContext *s); -/** - * Write the E-AC-3 frame header to the output bitstream. - */ -void ff_eac3_output_frame_header(AC3EncodeContext *s); - #endif /* AVCODEC_EAC3ENC_H */